Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36449 )
Change subject: mainboard/google: Allow Hatch variants to read SPD data over SMBus ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36449/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/36449/5/src/mainboard/google/hatch/... PS5, Line 25: READ_SMBUS
Did you decide to not use get_spd_smbus()?
I ended up going with FSP instead of a mix and match as it is a big awkward. This way the struct is just filled and your done.
https://review.coreboot.org/c/coreboot/+/36449/5/src/mainboard/google/hatch/... PS5, Line 42: variant_memory_params
Wouldn't the above configuration get overwritten by the weak implementation of variant_memory_params […]
Actually you are right. This is why I used the memcpy before this patch however it wasn't liked, can we just take the previous version and get this stuff moving forwards?
Frankly I just want us to get a building image of Puff then reshuffle things once the use-case is clear by letting the working code direct the design instead of designing too much ahead.