Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Marshall Dawson.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55028 )
Change subject: mb/google/guybrush/var/guybrush: Reconfigure left speaker amplifier
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55028/comment/57b68f98_c3dc46dc
PS1, Line 147: device i2c 2a on end
Not that there are two entries with uid=0, does this require "probed" property as well?
Done. Updated the uid to 2. Also set the probed property so that the kernel I2C driver can probe and add the concerned I2C device. Tested this on Guybrush board version 1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55028
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69a7e7dd65a459c2e5629ada1dea1f1660dd9990
Gerrit-Change-Number: 55028
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 02 Jun 2021 06:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment