Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47602 )
Change subject: arch/arm: Replace .id section with build_info in CBFS ......................................................................
Patch Set 7: Code-Review+2
Well it turned out backwards flashrom compatibility needs null-terminated strings.
Weren't they with your new patch? Normal .rodata from version.c should also be null-terminated.
And FILO has assumptions for the vendor and part number strings to be next to each other.
Okay, that's unfortunate. I mean, there are still ways to merge this with version.c... e.g. you could have an explicitly named linker section for each string to make sure they appear in the right order, or define them in version.c as `CONFIG_VERSION "\0" CONFIG_MAINBOARD_VENDOR "\0" CONFIG_MAINBOARD_PART_NUMBER` and then get the individual components with sizeof() math. But that starts becoming so complicated to follow that it's maybe not really an improvement anymore.