Attention is currently required from: Patrick Rudolph, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44869 )
Change subject: arch/x86: x86_64 implies SSE2 support ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44869/comment/5f3113cf_21c75aa1 PS2, Line 11: Tested on qemu.
Could you add the information from CB:68648 please? Test results are the same with this patch. […]
Welp, your reply sounded like you didn't want to update the commit message, so we rewrote the entire message as a suggestion... 😅
``` arch/x86: Enable SSE2 support on x86_64
Enable SSE2 when compiling for x86_64, as compilers assume SSE2 is available and many things will break if it's not the case.
For example, commit d91f3a4eaf7f8399db83a9c2d5cba2452fefaf7a ("lib/lzma: Build the source for decompression with flag -Ofast") enabled the -Ofast optimizations for LZMA at build time, but these break loading compressed stages on at least QEMU i440fx when using 64-bit coreboot, which results in a boot loop when attempting to load ramstage.
TEST=Ensure that `configs/config.emulation_qemu_x86_i440fx_x86_64` is is able to reach the payload instead of boot-looping when trying to load ramstage. Payload-specific functionality not tested. ```
If you like it, feel free to use it. Maybe add a paragraph about the issues with clang?
[And don't mind the wrapping, it's under 72 characters but Gerrit wraps the comments...]