[coreboot-gerrit] [S] Change in coreboot[main]: nb/intel/sandybridge: Add CFR objects for existing options

[Matt DeVillier (Code Review)]

Attention is currently required from: Angel Pons, Intel coreboot Reviewers.

Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87388?usp=email )

Change subject: nb/intel/sandybridge: Add CFR objects for existing options
......................................................................

Patch Set 2:

(3 comments)

File src/northbridge/intel/sandybridge/cfr.h:

https://review.coreboot.org/c/coreboot/+/87388/comment/01fda7fc_733b1864?usp... :
PS1, Line 7: #include <drivers/option/cfr_frontend.h>
> yep, will fix

Done

https://review.coreboot.org/c/coreboot/+/87388/comment/859a6694_999b291b?usp... :
PS1, Line 12: /* Values must match nb/sandybridge/Kconfig */
> I don't remember seeing IGD UMA size in Kconfig...

it's at the very bottom:

```
config IGD_DEFAULT_UMA_INDEX
    int
    default 0 if IGD_DEFAULT_UMA_SIZE_32MB
    default 1 if IGD_DEFAULT_UMA_SIZE_64MB
    default 2 if IGD_DEFAULT_UMA_SIZE_96MB
    default 3 if IGD_DEFAULT_UMA_SIZE_128MB
```

https://review.coreboot.org/c/coreboot/+/87388/comment/10640770_7d69e1f8?usp... :
PS1, Line 17: 1282
> typo, will fix

Done