Attention is currently required from: Sean Rhodes, Martin L Roth, Paul Menzel.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74825 )
Change subject: Documentation/contributing: Add sign-off procedure ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74825/comment/b23a7590_b90dd260 PS1, Line 14: sign : off
In the summary/title you spelled it Sign-off.
Done, moved this section into CB:74851 and fixed it there.
https://review.coreboot.org/c/coreboot/+/74825/comment/4276b2e8_736b9988 PS1, Line 14: In addition, the Linux kernel recently updated the wording of their sign : off procedure, changing the ambiguous "real name" requirement to "a : known identity" and dropping "no pseudonyms". Anonymous contributions : remain uncommittable [1]. As discussed in the April 19, 2023 leadership : meeting, update our policy to go along with Linux and flashrom (who also : updated their policy).
I’d make that a separate commit.
Done. Split into CB:74851.
File Documentation/contributing/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/74825/comment/78acec97_66137e98 PS1, Line 135:
Should the spaces be there?
Done
https://review.coreboot.org/c/coreboot/+/74825/comment/13599f97_6b7b2140 PS1, Line 142: pushed to gerrit, and will be rejected by coreboot's CI system.
Remove the trailing space?
Done
https://review.coreboot.org/c/coreboot/+/74825/comment/f5801e7a_9092f328 PS1, Line 148: [SCO-Linux disputes] for the rationale behind the DCO.
Remove the trailing space?
Done
https://review.coreboot.org/c/coreboot/+/74825/comment/b306a508_fecf194d PS1, Line 151: ```text : By making a contribution to this project, I certify that: : : (a) The contribution was created in whole or in part by me and I have : the right to submit it under the open source license indicated in the : file; or : : (b) The contribution is based upon previous work that, to the best of my : knowledge, is covered under an appropriate open source license and I : have the right under that license to submit that work with : modifications, whether created in whole or in part by me, under the same : open source license (unless I am permitted to submit under a different : license), as indicated in the file; or : : (c) The contribution was provided directly to me by some other person : who certified (a), (b) or (c) and I have not modified it; and : : (d) In the case of each of (a), (b), or (c), I understand and agree that : this project and the contribution are public and that a record of the : contribution (including all personal information I submit with it, : including my sign-off) is maintained indefinitely and may be : redistributed consistent with this project or the open source license : indicated in the file. : ```
I’d mark this up as a citation?
I'm not exactly sure what you mean by this? In the note under the DCO text, there is a link to the source at developercertificate.org. This is the same as what https://coreboot.org/developers.html, the old wiki, and flashrom's wiki do.