Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35958 )
Change subject: google/chell: Update ICC_MAX configuration
......................................................................
Patch Set 1:
Patch Set 1:
Oh yes, indeed. Do we need this CR then?
as long as the devicetree settings exist, they'll override the defaults in vr_config.c.
I'm guessing the intent is to be able to remove all the devicetree overrides unless they deviate from the SKU defaults. But until then, the devicetree settings need to be correct.
Well, that's what I mean - your CR is based on 35167, so 35167 well be get merged before yours and then yours is obsolete :-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia31ce432cf979d574d84e9205a287f87de5de057
Gerrit-Change-Number: 35958
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 12 Oct 2019 17:46:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment