Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )
Change subject: asus/p2b-ls: Replicate OEM configurations
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d...
File src/mainboard/asus/p2b-ls/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d...
PS3, Line 13: register "lid_polarity" = "1"
What is that good for on a desktop board?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38354
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee
Gerrit-Change-Number: 38354
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jan 2020 11:11:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment