[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/denverton_ns: Lock SPIBAR

[Steve Mooney (Code Review)]

Steve Mooney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25441 )

Change subject: soc/intel/denverton_ns: Lock SPIBAR
......................................................................

Patch Set 13: Code-Review-1

(2 comments)

Added one comment and one item that needs to be fixed.  The rest looks good to me.

https://review.coreboot.org/#/c/25441/13/src/soc/intel/denverton_ns/lpc.c 
File src/soc/intel/denverton_ns/lpc.c:

https://review.coreboot.org/#/c/25441/13/src/soc/intel/denverton_ns/lpc.c@36... 
PS13, Line 360: 			reg32 &= ~(SPIBAR_BIOS_CONTROL_EISS |
SPIBAR_BIOS_CONTROL_EISS changed to reserved in Denverton EDS 2.4, no explanation why.

https://review.coreboot.org/#/c/25441/13/src/soc/intel/denverton_ns/lpc.c@36... 
PS13, Line 361: 				   SPIBAR_BIOS_CONTROL_WPD);
SPIBAR_BIOS_CONTROL_WPD needs to be set to 1 to disable write protection.