Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c File util/inteltool/usb.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@226 PS6, Line 226: u8 uint8_t
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@242 PS6, Line 242: *(usbbase+usb_registers[i].addr) You need a pointer to uint32_t val to correctly read this value *((uint32_t*) (usbbase + usb_registers[i].addr))
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@244 PS6, Line 244: *(usbbase+usb_registers[i].addr+4)); *((uint32_t*) (usbbase + usb_registers[i].addr + 4))
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@249 PS6, Line 249: *(usbbase+usb_registers[i].addr) *((uint32_t*) (usbbase + usb_registers[i].addr + 4))
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@255 PS6, Line 255: *(usbbase+usb_registers[i].addr) *((uint16_t*) (usbbase + usb_registers[i].addr + 4))