Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33452 )
Change subject: soc/fsp_broadwell_de: Configure serial port UPDs correctly ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33452/1/src/soc/intel/fsp_broadwell_de/fsp/c... File src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c:
https://review.coreboot.org/#/c/33452/1/src/soc/intel/fsp_broadwell_de/fsp/c... PS1, Line 69: SerialPortControllerInit0
The thing is that `INTEGRATED_UART` seems to be a badly named debug […]
The reason route 2 was used on wedge was to fix serial output without breaking other platforms (and not getting a headache trying to understand what those UPDs are meant to do, and what they actually do).
https://review.coreboot.org/#/c/33452/1/src/soc/intel/fsp_broadwell_de/fsp/c... PS1, Line 74: SerialPortType
The value should depend on the several DRIVERS_UART_8250* configs. […]
8bit.