Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42015 )
Change subject: mb/google/zork: Add HID for max98357a
......................................................................
Patch Set 2:
(1 comment)
I missed to publish my comment. Please keep it in mind for the future.
https://review.coreboot.org/c/coreboot/+/42015/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42015/1//COMMIT_MSG@9
PS1, Line 9: The default HID was removed by a1c82c5ebee. We need to explicitly
Gerrit does not highlight it. Do you need to add *commit* before the hash?
Please use the style below anyway:
commit a1c82c5ebee (drivers/generic/max98357a: Allow custom _HID from config)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e
Gerrit-Change-Number: 42015
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jun 2020 14:57:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment