Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41884/8/src/drivers/intel/dptf/dptf...
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/8/src/drivers/intel/dptf/dptf...
PS8, Line 24: #ifndef CONFIG_DPTF_CPU_ADDR
: CONFIG_DPTF_CPU_ADDR = 0x00040000ul,
: #endif
Isn't this the PCI device address for the CPU thermal device? […]
nm, forgot about acpigen_write_ADR_pci_device
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief69a57adce9ee0b19056ce6a11ed8a5b51b3f87
Gerrit-Change-Number: 41884
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 20:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment