Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63365 )
Change subject: soc/intel/alderlake: Add support to update CSE descriptor at runtime ......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/alderlake/bootblock/cse_descriptor.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145364): https://review.coreboot.org/c/coreboot/+/63365/comment/6294f711_b4b87411 PS1, Line 40: void configure_cse_descriptor(size_t byte, uint8_t desired_value) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145364): https://review.coreboot.org/c/coreboot/+/63365/comment/bc7c9d95_f0abf10d PS1, Line 58: printk(BIOS_DEBUG, "Current value of Descriptor byte 0x%lx: 0x%x\n", byte, si_desc_buf[byte]); line over 96 characters