Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47013 )
Change subject: mb/google/dedede/var/metaknight: Add device settings ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47013/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47013/1//COMMIT_MSG@14 PS1, Line 14: 5. Add WiFi configuration
metaknight is using CNVi.
The WiFi configuration that you added in overridetree.cb is for discrete WiFi and is not required. CNVi configuration is already part of baseboard devicetree.cb.
Also please disable the USB2 port i.e. port 2.4 which is being used for Discrete Bluetooth.
https://review.coreboot.org/c/coreboot/+/47013/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/metaknight/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47013/1/src/mainboard/google/dedede... PS1, Line 106: "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)"
I should change this to ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ) right?
Yes. For ELAN0000 Touchpad, since it is not a HID over I2C device please consult the data sheet for any recommendations.
Similarly for the Touchscreen devices, specifically for the HID over I2C, configure the IRQ lines as level triggered i.e. register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"