Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36431 )
Change subject: soc/intel/icelake: Remove redundant dependency check in cpu.c ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/cpu.c:
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... PS2, Line 23: if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) I don't think this is correct. The call below *assumes* spi flash, but the check is removed for it. It's very much conceivable (and happened on glk/apl) that first part of the boot was memory mapped by way of CSE even if using emmc device.
Yes, we have defaults in Kconfig that if it's x86 and boot device is spi flash then we say boot device is memory mapped. But it does not follow that if boot device is memory mapped then the boot device's media is spi flash.