Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/c_start.S File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/c_start.S@19 PS6, Line 19: #endif
What I mean is add this stanza to line 45 and remove the conditional around _start and .globl _start. It would result in the following sequence:
.globl _start _start: .globl _start _start:
If the assembler doesn't care then things just work. Does the above cause a compilation problem?
compiler won't complain unless we select RAMSTAGE_LOADS_FROM_ROMSTAGE from soc. Upon selecting RAMSTAGE_LOADS_FROM_ROMSTAGE config, we will get below error
CC ramstage/arch/x86/c_start.o src/arch/x86/c_start.S: Assembler messages: src/arch/x86/c_start.S:46: Error: symbol `_start' is already defined make: *** [Makefile:357: build/ramstage/arch/x86/c_start.o] Error 1
https://review.coreboot.org/c/coreboot/+/34752/8/src/arch/x86/exit_car.S File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/34752/8/src/arch/x86/exit_car.S@40 PS8, Line 40: * is enabled in c_start.S
loaded? you mean no segment selectors used?
my bad. added proper comments now
https://review.coreboot.org/c/coreboot/+/34752/8/src/arch/x86/exit_car.S@145 PS8, Line 145: call main
Shouldn't this be based on ENV_POSTCAR then? Why leave this part here?
Done