Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47584 )
Change subject: soc/amd: factor out vbnv_cmos_failed() into common block
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47584/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47584/3//COMMIT_MSG@7
PS3, Line 7: block
not block anymore.
I think it would also be helpful to have some text capturing the addition of vboot/ to amd/common in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47584
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f976c6c5a2a715e1a5372bb93fe657d0d86c848
Gerrit-Change-Number: 47584
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Nov 2020 19:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment