[coreboot-gerrit] Change in coreboot[master]: mb/gigabyte/ga-h61m-s2pv: Add ga-h61m-ds2v as a variant

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37483 )

Change subject: mb/gigabyte/ga-h61m-s2pv: Add ga-h61m-ds2v as a variant
......................................................................

Patch Set 3: Code-Review+2

(3 comments)

https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... 
File src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... 
PS1, Line 22: 			register "c1_battery" = "1"
> Sane defaults sounds very reasonable.

Ack

https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... 
PS1, Line 58: 			device pci 1c.7 off end	# Unused PCIe Port
Doesn't this mean that they stay enabled?

https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... 
PS1, Line 75: 						irq 0xf0 = 0x08
> Original comments were about the `irq` used for 0xf* registers. But I was […]

Done