Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt Papageorge, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55237 )
Change subject: soc/amd/common/fsp/pci: Add size field to PCIe interrupt routing HOB
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/common/fsp/pci/pci_routing_info.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120818):
https://review.coreboot.org/c/coreboot/+/55237/comment/49de8349_bd27b009
PS5, Line 18: } __packed *routing_hob;
need consistent spacing around '*' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55237
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaafae304f04a5f26d75a41a6d6fcb4ee69954d20
Gerrit-Change-Number: 55237
Gerrit-PatchSet: 5
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Jun 2021 22:29:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment