Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29990 )
Change subject: sb/{bd82x6x,i82801gx,ibexpeak,lynxpoint}: Use BIOS_CNTL macro
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29990/1/src/southbridge/intel/i82801gx/lpc.c
File src/southbridge/intel/i82801gx/lpc.c:
https://review.coreboot.org/#/c/29990/1/src/southbridge/intel/i82801gx/lpc.c...
PS1, Line 358: #if TEST_SMM_FLASH_LOCKDOWN
is this dead code ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d2b555ada9c2893af4f85422128f5a8b04e2fc6
Gerrit-Change-Number: 29990
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 02 Dec 2018 08:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment