Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46055 )
Change subject: security/intel/txt: Use `smm_region()` to get TSEG base ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Thanks for reminding me this has a weirdness.
https://review.coreboot.org/c/coreboot/+/46055/1/src/security/intel/txt/rams... File src/security/intel/txt/ramstage.c:
https://review.coreboot.org/c/coreboot/+/46055/1/src/security/intel/txt/rams... PS1, Line 239: tseg_base Code assumes this is specified in MiB units, and this will overflow unless shifted accordingly.
https://review.coreboot.org/c/coreboot/+/46055/1/src/security/intel/txt/rams... PS1, Line 255: (tseg_base * MiB) just `tseg_base`