Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29924 )
Change subject: nb/intel/gm45: Make fetching the blc_pwm freq its own function ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@673 PS1, Line 673: = -1 Initialization is unnecessary as you check `> 0`.
https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@684 PS1, Line 684: if (!strcmp(blc_pwm[i].ascii_string, edid_ascii_string)) { Please mention this tiny functional change in the commit message.
https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@746 PS1, Line 746: if (pwm_freq < 0) eeeek, it's unsigned