build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading
......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/#/c/31448/16/src/device/pci_rom.c
File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31448/16/src/device/pci_rom.c@188
PS16, Line 188: /* Set the start of shadow memory for this Integrated or Discrete VGA. */
line over 80 characters
https://review.coreboot.org/#/c/31448/16/src/device/pci_rom.c@191
PS16, Line 191: run_rom = (struct rom_header *)(uintptr_t)PCI_VGA_RAM_IMAGE_START;
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3269a0911e86ea07014484365c7c830485e52ec
Gerrit-Change-Number: 31448
Gerrit-PatchSet: 16
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 09 Jun 2019 13:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment