Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 17: available.
So I have to redo it cutting down to 72, not expand as Paul is asking? Also notice that I'm counting […]
Yes. Find an editor with a reflow function. I use Atom which has reflow and also a markdown preview plugin.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 25: > obtain the memory map from the PSP.
By the way, does FSP-M currently does anything?
Yes, as of this instant, FSP-M handles all the AGESA calls and we're not using FSP-S for anything. By the time you get this document merged, that might have changed.
For now, I'd just say that the functionality in FSP-M and FSP-S is still undetermined and will be decided in the upcoming weeks and months.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/inde... File Documentation/binaries/index.md:
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/inde... PS6, Line 2:
Because I want to leave the opportunity for Intel and Cavium also use the binaries documentation fol […]
Why not just let them do that if/when they decide to add their documentation? I appreciate the thought, I'm just worried that it will lead people to think that there's more documentation than there actually is.