31 May
2022
31 May
'22
5:31 p.m.
Attention is currently required from: Patrick Georgi, Jakub Czapiga. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64737 )
Change subject: commonlib: Clean up compiler.h ......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/compiler.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150164): https://review.coreboot.org/c/coreboot/+/64737/comment/5ca3c01c_78b74f0a PS2, Line 35: #define __always_inline inline __attribute__((__always_inline__)) Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/64737
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9644da594bb69133843c6b7f12ce50b2e45fd24b
Gerrit-Change-Number: 64737
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Georgi patrick@coreboot.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 00:31:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment