Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44708 )
Change subject: soc/mediatek/mt8192: Update initial settings of dramc ......................................................................
Patch Set 45:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44708/45/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44708/45/src/soc/mediatek/mt8192/dr... PS45, Line 3639: Remove one extra tab
https://review.coreboot.org/c/coreboot/+/44708/39/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44708/39/src/soc/mediatek/mt8192/dr... PS39, Line 182: memcpy(result, &cali->impedance.result, sizeof(result));
use a pointer to cali->impedance.result.
Done
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 177: = {0}
change to a pointer.
Ack