Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47298 )
Change subject: soc/intel/xeon_sp: Change the return type of get_iio_stack_info()
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47298/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47298/4//COMMIT_MSG@9
PS4, Line 9: This
The current code?
Done
https://review.coreboot.org/c/coreboot/+/47298/1/src/soc/intel/xeon_sp/chip_...
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/47298/1/src/soc/intel/xeon_sp/chip_...
PS1, Line 437: pci64bit_alloc_flag
It could be called it here. No need for a flag variable.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a03cbb0ebbb48cc052d4c082d359c0087aaeb3e
Gerrit-Change-Number: 47298
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 19:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment