Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42443 )
Change subject: mb/google/hatch: Reduce PchPmSlpAMinAssert to 98ms
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG@7
PS1, Line 7: 98ms
98 ms
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG@10
PS1, Line 10: time(98ms) from 2sec as the SLP_A pin is not connected on hatch.
Please add a space before the ( and the unit (SI unit is *s*).
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG@12
PS1, Line 12: Test=Verified on hatch
How is that time verified?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafd0ad8b3ab20cbd2463bf443d2f670fb7be414c
Gerrit-Change-Number: 42443
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 05:41:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment