[coreboot-gerrit] Change in coreboot[master]: soc/amd: Move southbridge_smi_set_eos to common/blocks/smi/smi_util

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kyösti Mälkki.
Hello Kyösti Mälkki,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/50415

to review the following change.

Change subject: soc/amd: Move southbridge_smi_set_eos to common/blocks/smi/smi_util
......................................................................

soc/amd: Move southbridge_smi_set_eos to common/blocks/smi/smi_util

Signed-off-by: Kyösti Mälkki 
Signed-off-by: Felix Held 
Change-Id: I69466143315c1c9870a97c9ef8f68ed85f38e779
---
M src/soc/amd/common/block/smi/smi_util.c
M src/soc/amd/picasso/smihandler.c
M src/soc/amd/stoneyridge/smihandler.c
3 files changed, 7 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/50415/1

diff --git a/src/soc/amd/common/block/smi/smi_util.c b/src/soc/amd/common/block/smi/smi_util.c
index 1e4561d..e3379f3 100644
--- a/src/soc/amd/common/block/smi/smi_util.c
+++ b/src/soc/amd/common/block/smi/smi_util.c
@@ -65,6 +65,13 @@
    smi_write32(SMI_REG_SMITRIG0, reg);
 }

+void southbridge_smi_set_eos(void)
+{
+	uint32_t reg = smi_read32(SMI_REG_SMITRIG0);
+	reg |= SMITRG0_EOS;
+	smi_write32(SMI_REG_SMITRIG0, reg);
+}
+
 void soc_route_sci(uint8_t event)
 {
    smi_write8(SMI_SCI_MAP(event), event);
diff --git a/src/soc/amd/picasso/smihandler.c b/src/soc/amd/picasso/smihandler.c
index 4931de8..faf4f7b 100644
--- a/src/soc/amd/picasso/smihandler.c
+++ b/src/soc/amd/picasso/smihandler.c
@@ -293,10 +293,3 @@
    if (smi_src & SMI_STATUS_SRC_4)
    	process_smi_sources(SMI_REG_SMISTS4);
 }
-
-void southbridge_smi_set_eos(void)
-{
-	uint32_t reg = smi_read32(SMI_REG_SMITRIG0);
-	reg |= SMITRG0_EOS;
-	smi_write32(SMI_REG_SMITRIG0, reg);
-}
diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c
index c8a113c..45dd07d 100644
--- a/src/soc/amd/stoneyridge/smihandler.c
+++ b/src/soc/amd/stoneyridge/smihandler.c
@@ -288,10 +288,3 @@
    if (smi_src & SMI_STATUS_SRC_4)
    	process_smi_sources(SMI_REG_SMISTS4);
 }
-
-void southbridge_smi_set_eos(void)
-{
-	uint32_t reg = smi_read32(SMI_REG_SMITRIG0);
-	reg |= SMITRG0_EOS;
-	smi_write32(SMI_REG_SMITRIG0, reg);
-}