James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31067 )
Change subject: mb/lenovo/x131e: add function key support
......................................................................
Patch Set 2: Code-Review-1
Ideally, instead of defining EC_CMD_NOTIFY_ACPI_* twice, <quanta/it8518/ec.h> should be included.
However, quanta/it8518/ec.h has conflicting definitions with acpi/ec.h
As the only use of quanta/it8518 is google/stout, which is almost identical to x131e, it8518 should be modified to work with the generic ACPI EC code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31067
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a01f37a8b54889b55e92c501c9350e6c68bd57
Gerrit-Change-Number: 31067
Gerrit-PatchSet: 2
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Feb 2019 11:37:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment