Ideally, instead of defining EC_CMD_NOTIFY_ACPI_* twice, <quanta/it8518/ec.h> should be included.

However, quanta/it8518/ec.h has conflicting definitions with acpi/ec.h
As the only use of quanta/it8518 is google/stout, which is almost identical to x131e, it8518 should be modified to work with the generic ACPI EC code.

Patch set 2:Code-Review -1

View Change

To view, visit change 31067. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a01f37a8b54889b55e92c501c9350e6c68bd57
Gerrit-Change-Number: 31067
Gerrit-PatchSet: 2
Gerrit-Owner: James <>
Gerrit-Reviewer: Alexander Couzens <>
Gerrit-Reviewer: Felix Held <>
Gerrit-Reviewer: James <>
Gerrit-Reviewer: Martin Roth <>
Gerrit-Reviewer: Matt DeVillier <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Tue, 12 Feb 2019 11:37:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment