Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32233 )
Change subject: chromeos: clean up "recovery" and "write protect" GPIOs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32233/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32233/1//COMMIT_MSG@15
PS1, Line 15: The cached value of the "recovery" GPIO is read only on certain
: boards which have a physical recovery switch.
Boards might have different ways of reporting recovery switches. […]
Right, but those can't be handled in this table anyway. They can continue to do flag_replace() in depthcharge to install a custom driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic17a98768703d7098480a9233b752fe5b201bd51
Gerrit-Change-Number: 32233
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 09 Apr 2019 00:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment