10 Mar
2020
10 Mar
'20
9:50 p.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39422 )
Change subject: mb/google/dedede: Add ACPI configuration for USB ports ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39422/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39422/2/src/mainboard/google/dedede... PS2, Line 331: PAD_CFG_GPO(GPP_H19, 1, DEEP), Please split this out into a separate commit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/39422
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e7b8f00102c96dcc295601359d3ecfbcd1bea00
Gerrit-Change-Number: 39422
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Mar 2020 21:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment