Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32906 )
Change subject: vboot: init dispaly when recovery request
......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/32906/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32906/1//COMMIT_MSG@7
PS1, Line 7: when
on
https://review.coreboot.org/#/c/32906/1//COMMIT_MSG@7
PS1, Line 7: dispaly
display
https://review.coreboot.org/#/c/32906/1//COMMIT_MSG@9
PS1, Line 9: Dispaly
Display
https://review.coreboot.org/#/c/32906/1//COMMIT_MSG@13
PS1, Line 13:
No space here
https://review.coreboot.org/#/c/32906/1/src/security/vboot/vboot_logic.c
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/#/c/32906/1/src/security/vboot/vboot_logic.c@347
PS1, Line 347: If recovery mode, do initialize display
On recovery mode, initialize display
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6ac611f51241373bca3e2b394a94dcd52d3fde7
Gerrit-Change-Number: 32906
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 May 2019 12:15:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment