Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Patch Set 13:
(2 comments)
Unless somebody wants to dig deeper into these 1k+ lines DSDT files, I'd prefer this to be tested before it's merged.
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/fron... File src/mainboard/lippert/frontrunner-af/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/fron... PS13, Line 1127: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ This seems wrong. It should be a device below PCI0.
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/touc... File src/mainboard/lippert/toucan-af/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/touc... PS13, Line 1126: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Same here.
It's hard to tell which parts below PCI0 apply to PCI0 (the root) and which apply to the PCI device 18.0. However, as most of the devices presented below are on bus 0 and not below 18.0 (see devicetree), declaring this PCI0 to be the root seems to be the safer bet.