Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63348 )
Change subject: mb/starlabs/labtop: Remove subsystem device ID ......................................................................
mb/starlabs/labtop: Remove subsystem device ID
Remove the subsystem device ID for HDA devices, so that the correct Intel [8086:xxxx] is used. This was an old workaround for Windows that is no longer required with a new driver.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I50c03a2df06af3ef1939afd0739e083a9056557f Reviewed-on: https://review.coreboot.org/c/coreboot/+/63348 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/starlabs/labtop/variants/cml/devicetree.cb M src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/starlabs/labtop/variants/cml/devicetree.cb b/src/mainboard/starlabs/labtop/variants/cml/devicetree.cb index c0077a4..b3d7f34 100644 --- a/src/mainboard/starlabs/labtop/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/labtop/variants/cml/devicetree.cb @@ -182,7 +182,6 @@ device pci 1f.1 off end # P2SB device pci 1f.2 hidden end # Power Management Controller device pci 1f.3 on # Intel HDA - subsystemid 0x10ec 0x1200 register "PchHdaAudioLinkHda" = "1" end device pci 1f.4 on end # SMBus diff --git a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb index 6264257..ed65f4e 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb @@ -232,7 +232,6 @@ device pci 1f.1 off end # P2SB device pci 1f.2 hidden end # Power Management Controller device pci 1f.3 on # Intel HDA - subsystemid 0x10ec 0x1200 register "PchHdaAudioLinkHdaEnable" = "1" end device pci 1f.4 on end # SMBus