Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 62:
(59 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/9c12a8c0_4e081276 PS62, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/d6313b14_1f77a253 PS62, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/53874095_75e1ed56 PS62, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/fa3e3c05_beaeb4af PS62, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/b38f024b_461aa81e PS62, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/c95be5eb_822f4916 PS62, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/f5d6c09d_f1ee4e7d PS62, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/5a882e86_639c820c PS62, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/13bd56d5_989c2b4e PS62, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/76ac0d76_f7e51fbf PS62, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/7716438d_c1710ad8 PS62, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/d2f0f84d_20c0e2e6 PS62, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/f12588aa_1ff03fd9 PS62, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/2bc41c5f_76ff5694 PS62, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/cd076a40_687e9f47 PS62, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/1043968a_832adf44 PS62, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/0eb0014f_5e9268d8 PS62, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/8206ee61_773aa8d9 PS62, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/c717ce26_beeec645 PS62, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/7d6f007b_e8eba975 PS62, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/cb1b3865_453089e9 PS62, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/f342d825_ae69bbda PS62, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/ffe5894a_316927b2 PS62, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/2623fbf5_77d4de7a PS62, Line 34: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/11deabe2_156f502d PS62, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/05203073_a5837f99 PS62, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/bc0266ce_dc0b98ce PS62, Line 73: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
File payloads/cbui/NuklearUI/NuklearRwNvram.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/975ce1f5_0ba678fc PS62, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/054dac15_eec66a6f PS62, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwPci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/27a0a205_782301bd PS62, Line 89: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/10adbf25_a0115f66 PS62, Line 93: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/c793bfa0_dc496496 PS62, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/bc76eb6f_edd30d23 PS62, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/3e2aed0b_d7c8dd7c PS62, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/637ba2fc_4ba8c7f0 PS62, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/95b46410_c5aec6c6 PS62, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/012ee973_5b1a55c2 PS62, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/fa63e634_4fd3e93d PS62, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/2288a353_534509d7 PS62, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/2a361faa_2ceaba1b PS62, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/969f9d35_d27a24f6 PS62, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/1e14b465_e9873bca PS62, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/9a3828cc_4a533356 PS62, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/aeb3de3f_84c5723a PS62, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/a1259254_76fd9ecb PS62, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/23d97244_602d2935 PS62, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/7eb5cb1f_bf59beb2 PS62, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/26870e67_423dbd93 PS62, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/f3e17da8_418dbfde PS62, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/7d9ceb7e_3a09f8e4 PS62, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/61850864_66805b8f PS62, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/14ccef46_6e4f70f0 PS62, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/9cc5dbba_571e6e12 PS62, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/d96c3427_bb7c0b53 PS62, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/a26edf31_90f4bf9b PS62, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/fb583683_4e341186 PS62, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/f1bd2937_ba7bff19 PS62, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/5f93e809_b9e6e56f PS62, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159896): https://review.coreboot.org/c/coreboot/+/23586/comment/e439c8dc_70b163a0 PS62, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const