[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Hook up GMA ACPI brightness controls

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32549 )

Change subject: soc/intel/common: Hook up GMA ACPI brightness controls
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... 
File src/soc/intel/common/block/graphics/graphics.c:

https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... 
PS6, Line 36: struct
> Nit, could be const.

Done

https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... 
PS6, Line 41: unused
> Why not pass it along? it looks really odd, especially because we need to […]

Done

https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... 
PS6, Line 43: struct
> Here too, in case.

Done