Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4 ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 103: child_res->limit &&
Why? doesn't it cover up errors?
Resource allocation for that child would still fail in pass 2 and get reported accordingly. And it also allows the resource allocation for rest of the children of the bridge.
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 271: resource->flags |= IORESOURCE_ASSIGNED;
Not clearing IORESOURCE_STORED means we must be called with all non-fixed resources without it set.
Shouldn't that be the expectation? IORESOURCE_STORED should be set only after the resource assignment is actually stored within the device.
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 333: 0x3df
Last parameter is the size.
Thanks for catching this: https://review.coreboot.org/c/coreboot/+/41737