Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 1: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 4: #include <console/console.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 5: #include <device/device.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 6: #include <drivers/i2c/generic/chip.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 8: #include <ec/google/chromeec/ec.h> : #include <ec/google/chromeec/i2c_tunnel/chip.h> : #include <string.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 12: #define EC_PNP_ID 0x0c09 : : extern struct chip_operations ec_google_chromeec_i2c_tunnel_ops; Not required.