Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem...
File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem...
PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
I don't understand using HATCH as a model, when the boards listed in Kconfig. […]
I generally agree with Michael's sentiment. But placing selects in
`Kconfig.name` is already common practice for a year or so or maybe
more. If somebody wants to stop that, this is not the right place to
discuss it.
If somebody feels strong about it, please discuss it on the mailing
list, and add lint scripts to prevent further spreading in case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4764f2c1243ea49bd08e0735865cc3cb7a66441f
Gerrit-Change-Number: 47051
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Sat, 31 Oct 2020 20:31:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment