[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Write EIP to secure S3

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42088 )

Change subject: soc/amd/picasso: Write EIP to secure S3
......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42088/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42088/5//COMMIT_MSG@22 
PS5, Line 22: One 
Once

https://review.coreboot.org/c/coreboot/+/42088/5//COMMIT_MSG@23 
PS5, Line 23: remove
Maybe "consider removing"?  We may just want to keep it so that we don't need to rely on the good graces of the compression utility.

https://review.coreboot.org/c/coreboot/+/42088/5/src/soc/amd/picasso/bootblo... 
File src/soc/amd/picasso/bootblock/bootblock.c:

https://review.coreboot.org/c/coreboot/+/42088/5/src/soc/amd/picasso/bootblo... 
PS5, Line 15: #include <stdbool.h>
I believe this can go away now.