Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40415 )
Change subject: mb/google/puff: add a region to cache SPD data ......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
How about this one?
if ROMSTAGE_SPD_SMBUS config FMDFILE string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-spd.fmd" if BOARD_ROMSIZE_KB_32768 default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB-spd.fmd" if BOARD_ROMSIZE_KB_16384 endif
if !ROMSTAGE_SPD_SMBUS config FMDFILE string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB.fmd" if BOARD_ROMSIZE_KB_16384 default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if BOARD_ROMSIZE_KB_32768 endif
Also I have another question about the RW_SPD_CACHE space selecting. Now I reduced 4kB space from RW_NVRAM to add RW_SPD_CACHE. Is it okay for NVRAM?