Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36165 )
Change subject: drivers/intel/fsp2_0: Move Debug options to "Debugging" ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36165/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/36165/3/src/Kconfig@727 PS3, Line 727: source "src/cpu/*/Kconfig.debug" Maybe change these to Kconfig.cpu_debug or something so we can add them from anywhere?
source "src/*/Kconfig.cpu_debug" source "src/*/*/Kconfig.cpu_debug" source "src/*/*/*/Kconfig.cpu_debug" source "src/*/*/*/*/Kconfig.cpu_debug"
Then we could add corresponding kconfig.debug files for the general section below.
https://review.coreboot.org/c/coreboot/+/36165/3/src/Kconfig@728 PS3, Line 728: drivers we could be consistent about starting with "src/..." either have it everywhere or remove it everywhere.
https://review.coreboot.org/c/coreboot/+/36165/3/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig.debug:
https://review.coreboot.org/c/coreboot/+/36165/3/src/drivers/intel/fsp2_0/Kc... PS3, Line 2: Put this inside a menu?