23 Dec
2019
23 Dec
'19
4:33 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37909 )
Change subject: mainboard/google/hatch: Remove MAX98357A assumption from baseboard ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37909/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37909/1/src/mainboard/google/hatch/... PS1, Line 5: select DRIVERS_GENERIC_MAX98357A if !BOARD_GOOGLE_PUFF
In general, just selecting DRIVERS_GENERIC_MAX98357A without any board-specific check should be harm […]
See comments on the base patch that introduces this branch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e7fed69a4c6d9610ac100da6bae147828ebfa81
Gerrit-Change-Number: 37909
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Mon, 23 Dec 2019 12:33:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment