Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36144 )
Change subject: arch/x86: Use a common cbmem_top implementation
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36144/4/src/arch/x86/cbmem.c
File src/arch/x86/cbmem.c:
https://review.coreboot.org/c/coreboot/+/36144/4/src/arch/x86/cbmem.c@19
PS4, Line 19: void *cbmem_top_romstage(void)
This function isn't declared.
https://review.coreboot.org/c/coreboot/+/36144/4/src/arch/x86/cbmem.c@24
PS4, Line 24: if (ENV_RAMSTAGE && cbmem_top_backup != NULL)
Clean this up as well? If this function is only used in romstage then we should remove all of this? Or make it work with the original intent.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36144
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d5a366d6f1bc76f26d459628237e6b2c8ae03ea
Gerrit-Change-Number: 36144
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:29:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment