Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56178 )
Change subject: WIP: mb/google/guybrush: Enable booting windows ......................................................................
WIP: mb/google/guybrush: Enable booting windows
We can't have a GPE in the _PRW, and a GpioInt in the _CRS. This is an invalid state according to Windows. For now comment out the wake configs.
The correct fix still needs more investigation. I think now that the upstream linux kernel supports [setting wake states](https://patches.linaro.org/patch/429434/) we might be able to remove the _PWR object.
BUG=b:186212501 TEST=Boot guybrush to windows
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Ib130bb4df912024e5148b53e15c92820bb2210d2 --- M src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h M src/mainboard/google/guybrush/variants/guybrush/overridetree.cb 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/56178/1
diff --git a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h index d73dc00..ff9f1da 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h @@ -69,7 +69,7 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
/* Enable EC sync interrupt */ -#define EC_ENABLE_SYNC_IRQ_GPIO +// #define EC_ENABLE_SYNC_IRQ_GPIO
/* EC sync irq */ #define EC_SYNC_IRQ GPIO_84 diff --git a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb index 88c7d42..cbc93b7 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb @@ -81,7 +81,7 @@ register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" - register "wake" = "GEVENT_22" + # register "wake" = "GEVENT_22" register "probed" = "1" device i2c 15 on end end @@ -160,7 +160,7 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""google,cros-ec-uart"" register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_21)" - register "wake" = "GEVENT_5" + # register "wake" = "GEVENT_5" register "uart" = "ACPI_UART_RAW_DEVICE(3000000, 64)" device generic 0 on probe FP FP_PRESENT