3 Sep
2020
3 Sep
'20
7:22 a.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45062 )
Change subject: drivers/genesyslogic/gl9755: Add driver for Genesys Logic GL9755 ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
What is the difference to `src/drivers/genesyslogic/gl9763e/`?
Ah, looks like a totally different device.
https://review.coreboot.org/c/coreboot/+/45062/2/src/drivers/genesyslogic/gl... File src/drivers/genesyslogic/gl9755/gl9755.h:
https://review.coreboot.org/c/coreboot/+/45062/2/src/drivers/genesyslogic/gl... PS2, Line 7: #define CFG 0x800 Please align the values using tabs. Maybe you can run the file through clang-format?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45062
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16048dde348be248c748d50ca4a8a62c8a781430
Gerrit-Change-Number: 45062
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Chuang benchuanggli@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Sep 2020 10:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment