Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37400 )
Change subject: sb/amd/{agesa,pi}: use ACPIMMIO common block wherever possible ......................................................................
Patch Set 7: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/37400/7/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/smbus_spd.c:
https://review.coreboot.org/c/coreboot/+/37400/7/src/southbridge/amd/agesa/h... PS7, Line 133: pm_write8(0x2c, ioBase | 1); follow-up with pm_write16()
https://review.coreboot.org/c/coreboot/+/37400/7/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/smbus_spd.c:
https://review.coreboot.org/c/coreboot/+/37400/7/src/southbridge/amd/pi/huds... PS7, Line 134: pm_write8(0x2c, ioBase | 1); follow-up pm_write16()